-
Notifications
You must be signed in to change notification settings - Fork 722
chore: Add werkzeug package to setup file #1098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add werkzeug package to setup file #1098
Conversation
@thinkingserious @tiwarishubham635 any chance to have a release with this fix? |
Hi! I have raised #1099 to fix the failing tests. Will get them merged and then we can review your PR too. |
Thanks @tiwarishubham635 :) |
HI @gopidesupavan @eladkal |
Sure let me have a look |
@tiwarishubham635 thank you for the assistance. |
@tiwarishubham635 it looks like python 2.7 is not compatible with latest werkzeug. Just checking 2.7 is way old is it still a requirement to support? |
You can do
you just need to find the compatible library versions to match the python versions |
I can check into this and support for latest python versions. However, removing old versions is a tricky part since some of our customers might still be using it. I can check with my team about this decision |
I think
should do the trick @gopidesupavan can you try it? |
Thanks elad for sending this, i was side tracked to another issue. |
@tiwarishubham635 can you assist with the tests? I am not sure what is the issue |
Looks like |
I'm not sure why. |
Just to check the issue exists due to the eol versions, can yo try removing them from here? |
@tiwarishubham635 updated |
Alright, looks like it's due to the EOL versions only. Let me check with my team if we can drop the support for these versions |
Noting that Airflow can not release new versions of sendgrid provider till this is resolved. This will impact sendgrid users who uses Airflow. We already got some questions in Airflow chat, I asked the users to contact sendgrid supoort as the sendgrid provider for Airflow is blocked till this fixed is released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @tiwarishubham635 any timeline for next release? |
werkzeug package is using https://github.com/sendgrid/sendgrid-python/blob/main/sendgrid/helpers/inbound/parse.py#L6. I think its mandatory package here.
In recently at airflow our CI is failing due to werkzeug package missing.
https://github.com/apache/airflow/actions/runs/14342959080/job/40206921048?pr=48819#step:6:2431
Fixes
A short description of what this PR does.
Checklist
If you have questions, please file a support ticket.